Update go_router/lib/src/misc/extensions.dart#9079
Update go_router/lib/src/misc/extensions.dart#9079hashemim66110 wants to merge 1 commit intoflutter:mainfrom
Conversation
change pushReplacementNamed type from void to Future<T?> and added returnValue to pushReplacementNamed method.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hashemim66110
changed the title
|
Thanks for the submission! In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review. I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review. |
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Hi @hashemim66110 in order to merge this can you write a test and bump package version and change log?
|
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to re-open or submit a new PR if you have the time to address the review comments. Thanks! |
4 participants
change pushReplacementNamed type from void to Future<T?> and added returnValue to pushReplacementNamed method.
i was making a program and i need to pushReplacementNamed in a part of it. i checked the Documentation and it says the method pushReplacementNamed is returning a value. but when i tried to use it by context extensions it didn't return a value and got an error saying this method is void and doesn't return a value. so i simply updated method to return a value.
i didn't found any related open issue in issue board.
If you need help, consider asking for advice on the @HajMorty pv on [Telegram].
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3